From: Paul Brossier <piem@piem.org>
Date: Thu, 6 Dec 2018 23:04:07 +0000 (+0100)
Subject: [effects] aubio_get_rubberband_opts returns -1 if parsing fails
X-Git-Url: https://git.aubio.org/?a=commitdiff_plain;h=4bb2e740abf5b202a1c4f0fc214751fd4e712886;p=aubio.git

[effects] aubio_get_rubberband_opts returns -1 if parsing fails
---

diff --git a/src/effects/rubberband_utils.c b/src/effects/rubberband_utils.c
index 0161ec95..17ce4e24 100644
--- a/src/effects/rubberband_utils.c
+++ b/src/effects/rubberband_utils.c
@@ -125,13 +125,14 @@ RubberBandOptions aubio_get_rubberband_opts(const char_t *mode)
       else if ( strcmp(params[i], "ChannelsApart" ) == 0 )         rboptions |= RubberBandOptionChannelsApart;
       else if ( strcmp(params[i], "ChannelsTogether" ) == 0 )      rboptions |= RubberBandOptionChannelsTogether;
       else {
-        AUBIO_WRN("rubberband_utils: did not understand option '%s', should be one of: "
+        AUBIO_ERR("rubberband_utils: did not understand option '%s', should be one of: "
           "StretchElastic|StretchPrecise, TransientsCrisp|TransientsMixed|TransientsSmooth, "
           "DetectorCompound|DetectorPercussive|DetectorSoft, PhaseLaminar|PhaseIndependent, "
           "ThreadingAuto|ThreadingNever|ThreadingAlways, WindowStandard|WindowLong|WindowShort, "
           "SmoothingOn|SmoothingOff, FormantShifted|FormantPreserved, "
           "PitchHighSpeed|PitchHighQuality|PitchHighConsistency, ChannelsApart|ChannelsTogether\n"
           , params[i]);
+        return -1;
       }
       free(params[i]);
     }