From: Paul Brossier <piem@piem.org>
Date: Wed, 28 Nov 2018 12:40:46 +0000 (+0100)
Subject: [notes] prevent null pointer dereference
X-Git-Tag: 0.4.9~143
X-Git-Url: https://git.aubio.org/?a=commitdiff_plain;h=c5ee1307bdc004e43302abeca1802c2692b33a8e;p=aubio.git

[notes] prevent null pointer dereference

thanks to @niugx
---

diff --git a/src/notes/notes.c b/src/notes/notes.c
index a3cc7411..fab3f833 100644
--- a/src/notes/notes.c
+++ b/src/notes/notes.c
@@ -83,6 +83,7 @@ aubio_notes_t * new_aubio_notes (const char_t * method,
   o->isready = 0;
 
   o->onset = new_aubio_onset (onset_method, o->onset_buf_size, o->hop_size, o->samplerate);
+  if (o->onset == NULL) goto fail;
   if (o->onset_threshold != 0.) aubio_onset_set_threshold (o->onset, o->onset_threshold);
   o->onset_output = new_fvec (1);
 
@@ -99,6 +100,9 @@ aubio_notes_t * new_aubio_notes (const char_t * method,
   o->note_buffer = new_fvec(o->median);
   o->note_buffer2 = new_fvec(o->median);
 
+  if (!o->onset_output || !o->pitch_output ||
+      !o->note_buffer || !o->note_buffer2) goto fail;
+
   o->curnote = -1.;
   o->newnote = 0.;