From: Paul Brossier <piem@piem.org>
Date: Sat, 17 Nov 2018 11:22:59 +0000 (+0100)
Subject: [filterbank] check norm in set_triangle_bands
X-Git-Tag: 0.4.8~46
X-Git-Url: https://git.aubio.org/?p=aubio.git;a=commitdiff_plain;h=831f70277a9d2528ed4b0ea4cee4f3013e277ebc

[filterbank] check norm in set_triangle_bands
---

diff --git a/src/spectral/filterbank_mel.c b/src/spectral/filterbank_mel.c
index 6b519158..6a521af2 100644
--- a/src/spectral/filterbank_mel.c
+++ b/src/spectral/filterbank_mel.c
@@ -90,9 +90,13 @@ aubio_filterbank_set_triangle_bands (aubio_filterbank_t * fb,
   }
 
   /* compute triangle heights so that each triangle has unit area */
-  for (fn = 0; fn < n_filters; fn++) {
-    triangle_heights->data[fn] =
-        2. / (upper_freqs->data[fn] - lower_freqs->data[fn]);
+  if (aubio_filterbank_get_norm(fb)) {
+    for (fn = 0; fn < n_filters; fn++) {
+      triangle_heights->data[fn] =
+          2. / (upper_freqs->data[fn] - lower_freqs->data[fn]);
+    }
+  } else {
+    fvec_ones (triangle_heights);
   }
 
   /* fill fft_freqs lookup table, which assigns the frequency in hz to each bin */
@@ -117,9 +121,8 @@ aubio_filterbank_set_triangle_bands (aubio_filterbank_t * fb,
     }
 
     /* compute positive slope step size */
-    riseInc =
-        triangle_heights->data[fn] /
-        (center_freqs->data[fn] - lower_freqs->data[fn]);
+    riseInc = triangle_heights->data[fn]
+      / (center_freqs->data[fn] - lower_freqs->data[fn]);
 
     /* compute coefficients in positive slope */
     for (; bin < win_s - 1; bin++) {
@@ -133,9 +136,8 @@ aubio_filterbank_set_triangle_bands (aubio_filterbank_t * fb,
     }
 
     /* compute negative slope step size */
-    downInc =
-        triangle_heights->data[fn] /
-        (upper_freqs->data[fn] - center_freqs->data[fn]);
+    downInc = triangle_heights->data[fn]
+      / (upper_freqs->data[fn] - center_freqs->data[fn]);
 
     /* compute coefficents in negative slope */
     for (; bin < win_s - 1; bin++) {